commit 9339f249dc53186630cd394e9890003d7423f47b
author Aleksander Wasaznik <aleksander.wasaznik@nordicsemi.no> Mon May 30 15:20:12 2022 +0200
committer Carles Cufí <carles.cufi@nordicsemi.no> Mon Jul 04 16:27:08 2022 +0200
tree 3d97da05ecc7f54821d2666cc324fe4a80acce66
parent 123c088c4a383db6b438d9cda3fad3ab35dcbac6

Bluetooth: Host: Refactor tx_notify, use `CONTAINER_OF`

The cast from `sys_snode_t` to `struct bt_conn_tx` assumes `node` is the
first field in `struct bt_conn_tx`. It's better to future-proof this by
using `CONTAINER_OF` to locate `node`.

Signed-off-by: Aleksander Wasaznik <aleksander.wasaznik@nordicsemi.no>

subsys/bluetooth/host/conn.c

diff --git a/subsys/bluetooth/host/conn.c b/subsys/bluetooth/host/conn.c
index 39d7140..a910240 100644
--- a/subsys/bluetooth/host/conn.c
+++ b/subsys/bluetooth/host/conn.c
@@ -200,7 +200,8 @@
 			break;
 		}
 
-		tx = (void *)sys_slist_get_not_empty(&conn->tx_complete);
+		tx = CONTAINER_OF(sys_slist_get_not_empty(&conn->tx_complete),
+				  struct bt_conn_tx, node);
 		irq_unlock(key);
 
 		BT_DBG("tx %p cb %p user_data %p", tx, tx->cb, tx->user_data);