commit c11af961352181bdd856de32bb513f495996dbde
author Michał Barnaś <mb@semihalf.com> Tue Sep 20 16:00:18 2022 +0200
committer Christopher Friedt <chrisfriedt@gmail.com> Tue Dec 06 10:10:36 2022 -0500
tree 56462067c22e4201cf2925de1966e2614269b70c
parent 673b0665d3871efbae0d57d945e080eaba250a1d

gpio: fix the nct38xx driver

This commit fixes the comment and adds the missing assignment of
return value from i2c read byte command in the nct38xx driver.

Signed-off-by: Michał Barnaś <mb@semihalf.com>

drivers/gpio/gpio_nct38xx_port.c

diff --git a/drivers/gpio/gpio_nct38xx_port.c b/drivers/gpio/gpio_nct38xx_port.c
index fabe360..78542f7 100644
--- a/drivers/gpio/gpio_nct38xx_port.c
+++ b/drivers/gpio/gpio_nct38xx_port.c
@@ -70,7 +70,7 @@
 		}
 
 		new_reg = reg | mask;
-		/* NCT3807 bit3 should be set to 0 */
+		/* NCT3807 bit3 must be set to 0 */
 		new_reg &= config->pinmux_mask;
 
 		ret = nct38xx_reg_update(config->nct38xx_dev, NCT38XX_REG_MUX_CONTROL, reg,
@@ -131,8 +131,8 @@
 
 	/* Configure pin as output, if requested 0:input 1:output */
 	if (flags & GPIO_OUTPUT) {
-		nct38xx_reg_read_byte(config->nct38xx_dev, NCT38XX_REG_GPIO_DIR(config->gpio_port),
-				      &reg);
+		ret = nct38xx_reg_read_byte(config->nct38xx_dev,
+					    NCT38XX_REG_GPIO_DIR(config->gpio_port), &reg);
 		if (ret < 0) {
 			goto done;
 		}