shell: modules: do not use k_thread_foreach with shell callbacks
Always use k_thread_foreach_unlocked with callbacks which print
something out to the shell, as they might call arch_irq_unlock.
Fixes #66660.
Signed-off-by: Benedikt Schmidt <benedikt.schmidt@embedded-solutions.at>
(cherry picked from commit 4c731f27c6da917d7f4abaa10270bb2440423b17)
diff --git a/subsys/shell/modules/kernel_service.c b/subsys/shell/modules/kernel_service.c
index 94940dd..8217f0f 100644
--- a/subsys/shell/modules/kernel_service.c
+++ b/subsys/shell/modules/kernel_service.c
@@ -141,11 +141,12 @@
shell_print(shell, "Scheduler: %u since last call", sys_clock_elapsed());
shell_print(shell, "Threads:");
-#ifdef CONFIG_SMP
+ /*
+ * Use the unlocked version as the callback itself might call
+ * arch_irq_unlock.
+ */
k_thread_foreach_unlocked(shell_tdata_dump, (void *)shell);
-#else
- k_thread_foreach(shell_tdata_dump, (void *)shell);
-#endif
+
return 0;
}
@@ -190,11 +191,11 @@
ARG_UNUSED(argc);
ARG_UNUSED(argv);
-#ifdef CONFIG_SMP
+ /*
+ * Use the unlocked version as the callback itself might call
+ * arch_irq_unlock.
+ */
k_thread_foreach_unlocked(shell_stack_dump, (void *)shell);
-#else
- k_thread_foreach(shell_stack_dump, (void *)shell);
-#endif
/* Placeholder logic for interrupt stack until we have better
* kernel support, including dumping arch-specific exception-related
