commit 0c70f3bad725c2389264eaea0bc4591fcebea1bc
author Yudong Zhang <mtwget@gmail.com> Wed Jan 11 14:40:44 2023 +0800
committer Marti Bolivar <marti.bolivar@nordicsemi.no> Mon Mar 27 14:20:50 2023 -0700
tree f7eb94047173bdc78beffc6f643ae1208bf4f767
parent 5875676425166ab206c8ffb9ec509778aeed06f1

shell: mqtt: fix call to bin2hex

Fixes: f2affbd ("os: lib: bin2hex: fix memory overwrite")
Signed-off-by: Yudong Zhang <mtwget@gmail.com>

subsys/shell/backends/shell_mqtt.c

diff --git a/subsys/shell/backends/shell_mqtt.c b/subsys/shell/backends/shell_mqtt.c
index 1179f09..028f27f 100644
--- a/subsys/shell/backends/shell_mqtt.c
+++ b/subsys/shell/backends/shell_mqtt.c
@@ -86,7 +86,7 @@
 	}
 
 	(void)memset(id, 0, id_max_len);
-	length = bin2hex(hwinfo_id, (size_t)length, id, id_max_len - 1);
+	length = bin2hex(hwinfo_id, (size_t)length, id, id_max_len);
 
 	return length > 0;
 }