Fix linter warnings with new buildifier version. (#122)
diff --git a/test/testdata/android_basic_test/input.bzl b/test/testdata/android_basic_test/input.bzl
index 11feec1..970b674 100644
--- a/test/testdata/android_basic_test/input.bzl
+++ b/test/testdata/android_basic_test/input.bzl
@@ -1,5 +1,6 @@
# buildifier: disable=module-docstring
# buildifier: disable=function-docstring
+# buildifier: disable=unused-variable
def exercise_the_api():
_var1 = android_common.create_device_broker_info("")
_var2 = ApkInfo
@@ -13,8 +14,10 @@
exercise_the_api()
def my_rule_impl(ctx):
+ _ignore = [ctx] # @unused
return []
+# buildifier: disable=unsorted-dict-items
android_related_rule = rule(
implementation = my_rule_impl,
doc = "This rule does android-related things.",
diff --git a/test/testdata/angle_bracket_test/input.bzl b/test/testdata/angle_bracket_test/input.bzl
index 0f3a45c..69daa7a 100644
--- a/test/testdata/angle_bracket_test/input.bzl
+++ b/test/testdata/angle_bracket_test/input.bzl
@@ -12,8 +12,10 @@
some <angled> brackets
"""
+ _ignore = name # @unused
pass
+# buildifier: disable=unsorted-dict-items
bracketuse = provider(
doc = "Information with <brackets>",
fields = {
@@ -24,6 +26,7 @@
)
def _rule_impl(ctx):
+ _ignore = [ctx] # @unused
return []
my_anglebrac = rule(
diff --git a/test/testdata/apple_basic_test/input.bzl b/test/testdata/apple_basic_test/input.bzl
index c5801ba..d5e89de 100644
--- a/test/testdata/apple_basic_test/input.bzl
+++ b/test/testdata/apple_basic_test/input.bzl
@@ -1,15 +1,17 @@
# buildifier: disable=module-docstring
# buildifier: disable=function-docstring
def exercise_the_api():
- var1 = apple_common.platform_type
- var2 = apple_common.AppleDynamicFramework
+ var1 = apple_common.platform_type # @unused
+ var2 = apple_common.AppleDynamicFramework # @unused
exercise_the_api()
# buildifier: disable=rule-impl-return
def my_rule_impl(ctx):
+ _ignore = [ctx] # @unused
return struct()
+# buildifier: disable=unsorted-dict-items
apple_related_rule = rule(
implementation = my_rule_impl,
doc = "This rule does apple-related things.",
diff --git a/test/testdata/aspect_test/input.bzl b/test/testdata/aspect_test/input.bzl
index 1ffedb4..72e35a5 100644
--- a/test/testdata/aspect_test/input.bzl
+++ b/test/testdata/aspect_test/input.bzl
@@ -1,6 +1,7 @@
"""The input file for the aspect test"""
def my_aspect_impl(ctx):
+ _ignore = [ctx] # @unused
return []
my_aspect = aspect(
@@ -13,6 +14,7 @@
},
)
+# buildifier: disable=unsorted-dict-items
other_aspect = aspect(
implementation = my_aspect_impl,
doc = "This is another aspect.",
diff --git a/test/testdata/attribute_defaults_test/input.bzl b/test/testdata/attribute_defaults_test/input.bzl
index 68c83f1..3b531b3 100644
--- a/test/testdata/attribute_defaults_test/input.bzl
+++ b/test/testdata/attribute_defaults_test/input.bzl
@@ -1,11 +1,14 @@
"""A golden test to verify attribute default values."""
def _my_rule_impl(ctx):
+ _ignore = [ctx] # @unused
return []
def _my_aspect_impl(target, ctx):
+ _ignore = [target, ctx] # @unused
return []
+# buildifier: disable=unsorted-dict-items
my_aspect = aspect(
implementation = _my_aspect_impl,
doc = "This is my aspect. It does stuff.",
@@ -17,6 +20,7 @@
},
)
+# buildifier: disable=unsorted-dict-items
my_rule = rule(
implementation = _my_rule_impl,
doc = "This is my rule. It does stuff.",
diff --git a/test/testdata/attribute_types_test/input.bzl b/test/testdata/attribute_types_test/input.bzl
index adbe695..92c037c 100644
--- a/test/testdata/attribute_types_test/input.bzl
+++ b/test/testdata/attribute_types_test/input.bzl
@@ -1,6 +1,7 @@
# buildifier: disable=module-docstring
# buildifier: disable=function-docstring
def my_rule_impl(ctx):
+ _ignore = [ctx] # @unused
return []
my_rule = rule(
diff --git a/test/testdata/cc_api_test/input.bzl b/test/testdata/cc_api_test/input.bzl
index 10f46e1..9a4365f 100644
--- a/test/testdata/cc_api_test/input.bzl
+++ b/test/testdata/cc_api_test/input.bzl
@@ -1,13 +1,15 @@
"""Input file for C++ api test"""
def exercise_the_api():
- var1 = CcInfo
+ var1 = CcInfo # @unused
exercise_the_api()
def my_rule_impl(ctx):
+ _ignore = [ctx] # @unused
return []
+# buildifier: disable=unsorted-dict-items
cpp_related_rule = rule(
implementation = my_rule_impl,
doc = "This rule does C++-related things.",
diff --git a/test/testdata/config_apis_test/input.bzl b/test/testdata/config_apis_test/input.bzl
index 9d871b8..fb2a8ce 100644
--- a/test/testdata/config_apis_test/input.bzl
+++ b/test/testdata/config_apis_test/input.bzl
@@ -1,7 +1,7 @@
# buildifier: disable=module-docstring
# buildifier: disable=function-docstring
def exercise_the_api():
- _var6 = configuration_field("foo", "bar")
+ _var6 = configuration_field("foo", "bar") # @unused
exercise_the_api()
@@ -12,6 +12,7 @@
my_transition = transition(implementation = transition_func, inputs = [], outputs = [])
def _build_setting_impl(ctx):
+ _ignore = [ctx] # @unused
return []
string_flag = rule(
diff --git a/test/testdata/cpp_basic_test/input.bzl b/test/testdata/cpp_basic_test/input.bzl
index b927e42..985ad0c 100644
--- a/test/testdata/cpp_basic_test/input.bzl
+++ b/test/testdata/cpp_basic_test/input.bzl
@@ -1,13 +1,15 @@
# buildifier: disable=module-docstring
# buildifier: disable=function-docstring
def exercise_the_api():
- var1 = cc_common.CcToolchainInfo
+ var1 = cc_common.CcToolchainInfo # @unused
exercise_the_api()
def my_rule_impl(ctx):
+ _ignore = [ctx] # @unused
return []
+# buildifier: disable=unsorted-dict-items
cpp_related_rule = rule(
implementation = my_rule_impl,
doc = "This rule does cpp-related things.",
diff --git a/test/testdata/filter_rules_test/dep.bzl b/test/testdata/filter_rules_test/dep.bzl
index 1cff158..4368e33 100644
--- a/test/testdata/filter_rules_test/dep.bzl
+++ b/test/testdata/filter_rules_test/dep.bzl
@@ -1,5 +1,6 @@
# buildifier: disable=module-docstring
def my_rule_impl(ctx):
+ _ignore = [ctx] # @unused
return []
my_rule = rule(
diff --git a/test/testdata/filter_rules_test/input.bzl b/test/testdata/filter_rules_test/input.bzl
index 961c4dd..5d05b9b 100644
--- a/test/testdata/filter_rules_test/input.bzl
+++ b/test/testdata/filter_rules_test/input.bzl
@@ -5,6 +5,7 @@
)
def my_rule_impl(ctx):
+ _ignore = [ctx] # @unused
return []
my_rule = rule(
diff --git a/test/testdata/function_basic_test/input.bzl b/test/testdata/function_basic_test/input.bzl
index cff5b48..93bf711 100644
--- a/test/testdata/function_basic_test/input.bzl
+++ b/test/testdata/function_basic_test/input.bzl
@@ -31,8 +31,8 @@
int_param,
dict_param,
struct_param,
- ]
- x = ("Hah. All that documentation but nothing really to see here")
+ ] # @unused
+ x = ("Hah. All that documentation but nothing really to see here") # @unused
def returns_a_thing(name):
"""Returns a suffixed name.
@@ -43,6 +43,7 @@
Returns:
A suffixed version of the name.
"""
+ _ignore = name # @unused
pass
def deprecated_do_not_use():
@@ -54,4 +55,5 @@
pass
def undocumented_function(a, b, c):
+ _ignore = [a, b, c] # @unused
pass
diff --git a/test/testdata/html_tables_template_test/input.bzl b/test/testdata/html_tables_template_test/input.bzl
index 23f3379..42ca4ac 100644
--- a/test/testdata/html_tables_template_test/input.bzl
+++ b/test/testdata/html_tables_template_test/input.bzl
@@ -7,8 +7,10 @@
foo: This parameter does foo related things.
bar: This parameter does bar related things.
"""
+ _ignore = [foo, bar] # @unused
pass
+# buildifier: disable=unsorted-dict-items
ExampleProviderInfo = provider(
doc = "Small example of provider using a markdown template.",
fields = {
@@ -19,6 +21,7 @@
)
def _rule_impl(ctx):
+ _ignore = [ctx] # @unused
return []
example_rule = rule(
@@ -31,6 +34,7 @@
)
def _aspect_impl(ctx):
+ _ignore = [ctx] # @unused
return []
example_aspect = aspect(
diff --git a/test/testdata/input_template_test/input.bzl b/test/testdata/input_template_test/input.bzl
index 37fee12..d47d025 100644
--- a/test/testdata/input_template_test/input.bzl
+++ b/test/testdata/input_template_test/input.bzl
@@ -9,8 +9,10 @@
Args:
foo: A unique name for this function.
"""
+ _ignore = [foo] # @unused
pass
+# buildifier: disable=unsorted-dict-items
example = provider(
doc = "Stores information about an example in chosen template.",
fields = {
@@ -21,6 +23,7 @@
)
def _rule_impl(ctx):
+ _ignore = [ctx] # @unused
return []
my_example = rule(
@@ -35,6 +38,7 @@
)
def my_aspect_impl(ctx):
+ _ignore = [ctx] # @unused
return []
my_aspect = aspect(
diff --git a/test/testdata/java_basic_test/input.bzl b/test/testdata/java_basic_test/input.bzl
index db0d064..d61141f 100644
--- a/test/testdata/java_basic_test/input.bzl
+++ b/test/testdata/java_basic_test/input.bzl
@@ -1,15 +1,17 @@
# buildifier: disable=module-docstring
# buildifier: disable=function-docstring
def exercise_the_api():
- var1 = java_common.JavaRuntimeInfo
- var2 = JavaInfo
- var3 = java_proto_common
+ var1 = java_common.JavaRuntimeInfo # @unused
+ var2 = JavaInfo # @unused
+ var3 = java_proto_common # @unused
exercise_the_api()
def my_rule_impl(ctx):
+ _ignore = [ctx] # @unused
return []
+# buildifier: disable=unsorted-dict-items
java_related_rule = rule(
implementation = my_rule_impl,
doc = "This rule does java-related things.",
diff --git a/test/testdata/local_repository_test/input.bzl b/test/testdata/local_repository_test/input.bzl
index 59e5b42..fdd686b 100644
--- a/test/testdata/local_repository_test/input.bzl
+++ b/test/testdata/local_repository_test/input.bzl
@@ -11,5 +11,5 @@
Returns:
The minimum integer in the given list.
"""
- _ignore = [integers]
+ _ignore = [integers] # @unused
return give_me_five()
diff --git a/test/testdata/macro_kwargs_test/input.bzl b/test/testdata/macro_kwargs_test/input.bzl
index 0f6268d..8de782e 100644
--- a/test/testdata/macro_kwargs_test/input.bzl
+++ b/test/testdata/macro_kwargs_test/input.bzl
@@ -18,7 +18,7 @@
Returns:
An empty list.
"""
- _ignore = [name, config, deps, kwargs]
+ _ignore = [name, config, deps, kwargs] # @unused
return []
def macro_with_args(name, *args):
@@ -31,7 +31,7 @@
Returns:
An empty list.
"""
- _ignore = [name, args]
+ _ignore = [name, args] # @unused
return []
def macro_with_both(name, number = 3, *args, **kwargs):
@@ -48,5 +48,5 @@
Returns:
An empty list.
"""
- _ignore = [name, number, args, kwargs]
+ _ignore = [name, number, args, kwargs] # @unused
return []
diff --git a/test/testdata/misc_apis_test/input.bzl b/test/testdata/misc_apis_test/input.bzl
index 4796b49..63ea94a 100644
--- a/test/testdata/misc_apis_test/input.bzl
+++ b/test/testdata/misc_apis_test/input.bzl
@@ -4,20 +4,22 @@
config = "value for global config variable"
def my_rule_impl(ctx):
+ _ignore = [ctx] # @unused
return []
def exercise_the_api():
- var1 = config_common.FeatureFlagInfo
- var2 = platform_common.TemplateVariableInfo
+ var1 = config_common.FeatureFlagInfo # @unused
+ var2 = platform_common.TemplateVariableInfo # @unused
var3 = repository_rule(
implementation = my_rule_impl,
doc = "This repository rule has documentation.",
- )
- var4 = testing.ExecutionInfo({})
+ ) # @unused
+ var4 = testing.ExecutionInfo({}) # @unused
exercise_the_api()
# buildifier: disable=provider-params
+# buildifier: disable=unsorted-dict-items
MyInfo = provider(
fields = {
"foo": "Something foo-related.",
@@ -27,6 +29,7 @@
my_info = MyInfo(foo = "x", bar = "y")
+# buildifier: disable=unsorted-dict-items
my_rule = rule(
implementation = my_rule_impl,
doc = "This rule exercises some of the build API.",
diff --git a/test/testdata/multi_level_namespace_test/input.bzl b/test/testdata/multi_level_namespace_test/input.bzl
index 8b0b436..0a5aa11 100644
--- a/test/testdata/multi_level_namespace_test/input.bzl
+++ b/test/testdata/multi_level_namespace_test/input.bzl
@@ -9,7 +9,7 @@
Returns:
The minimum integer in the given list.
"""
- _ignore = [integers]
+ _ignore = [integers] # @unused
return 42
def _does_nothing():
diff --git a/test/testdata/multi_level_namespace_test_with_whitelist/input.bzl b/test/testdata/multi_level_namespace_test_with_whitelist/input.bzl
index 34eb87b..f070309 100644
--- a/test/testdata/multi_level_namespace_test_with_whitelist/input.bzl
+++ b/test/testdata/multi_level_namespace_test_with_whitelist/input.bzl
@@ -4,7 +4,7 @@
def _min(integers):
"""Returns the minimum of given elements."""
- _ignore = [integers]
+ _ignore = [integers] # @unused
return 42
def _does_nothing():
diff --git a/test/testdata/multiple_files_test/dep.bzl b/test/testdata/multiple_files_test/dep.bzl
index b1beece..75a0b21 100644
--- a/test/testdata/multiple_files_test/dep.bzl
+++ b/test/testdata/multiple_files_test/dep.bzl
@@ -10,7 +10,7 @@
srcs: What sources you want cool stuff to happen to.
beef: Your opinion on beef.
"""
- x = (name, srcs, beef)
+ x = (name, srcs, beef) # @unused
prep_work()
diff --git a/test/testdata/multiple_files_test/inner_dep.bzl b/test/testdata/multiple_files_test/inner_dep.bzl
index 16d4361..6d4b582 100644
--- a/test/testdata/multiple_files_test/inner_dep.bzl
+++ b/test/testdata/multiple_files_test/inner_dep.bzl
@@ -5,5 +5,5 @@
return 1
def inner_rule_impl(ctx):
- _ignore = [ctx]
+ _ignore = [ctx] # @unused
return struct()
diff --git a/test/testdata/multiple_files_test/input.bzl b/test/testdata/multiple_files_test/input.bzl
index 5b46c54..0e033f1 100644
--- a/test/testdata/multiple_files_test/input.bzl
+++ b/test/testdata/multiple_files_test/input.bzl
@@ -19,6 +19,7 @@
some_cool_function(a, b, c)
return 6
+# buildifier: disable=unsorted-dict-items
other_rule = rule(
implementation = my_rule_impl,
doc = "This is another rule.",
diff --git a/test/testdata/multiple_rules_test/input.bzl b/test/testdata/multiple_rules_test/input.bzl
index 7a2d314..bb601e5 100644
--- a/test/testdata/multiple_rules_test/input.bzl
+++ b/test/testdata/multiple_rules_test/input.bzl
@@ -1,5 +1,6 @@
# buildifier: disable=module-docstring
def my_rule_impl(ctx):
+ _ignore = [ctx] # @unused
return []
my_rule = rule(
@@ -11,6 +12,7 @@
},
)
+# buildifier: disable=unsorted-dict-items
other_rule = rule(
implementation = my_rule_impl,
doc = "This is another rule.",
@@ -21,6 +23,7 @@
},
)
+# buildifier: disable=unsorted-dict-items
yet_another_rule = rule(
implementation = my_rule_impl,
doc = "This is yet another rule",
diff --git a/test/testdata/namespace_test/input.bzl b/test/testdata/namespace_test/input.bzl
index 69cad64..eaf256d 100644
--- a/test/testdata/namespace_test/input.bzl
+++ b/test/testdata/namespace_test/input.bzl
@@ -9,7 +9,7 @@
Returns:
The minimum integer in the given list.
"""
- _ignore = [integers]
+ _ignore = [integers] # @unused
return 42
def _assert_non_empty(some_list, other_list):
@@ -19,7 +19,7 @@
some_list: The first list
other_list: The second list
"""
- _ignore = [some_list, other_list]
+ _ignore = [some_list, other_list] # @unused
fail("Not implemented")
def _join_strings(strings, delimiter = ", "):
@@ -32,7 +32,7 @@
Returns:
The joined string.
"""
- _ignore = [strings, delimiter]
+ _ignore = [strings, delimiter] # @unused
return ""
my_namespace = struct(
diff --git a/test/testdata/proto_format_test/input.bzl b/test/testdata/proto_format_test/input.bzl
index aee171e..c076b3f 100644
--- a/test/testdata/proto_format_test/input.bzl
+++ b/test/testdata/proto_format_test/input.bzl
@@ -9,8 +9,10 @@
Args:
foo: A unique name for this rule.
"""
+ _ignore = foo # @unused
pass
+# buildifier: disable=unsorted-dict-items
example = provider(
doc = "Stores information about an example.",
fields = {
@@ -21,6 +23,7 @@
)
def _rule_impl(ctx):
+ _ignore = [ctx] # @unused
return []
my_example = rule(
diff --git a/test/testdata/provider_basic_test/input.bzl b/test/testdata/provider_basic_test/input.bzl
index 4003a05..bb76c0d 100644
--- a/test/testdata/provider_basic_test/input.bzl
+++ b/test/testdata/provider_basic_test/input.bzl
@@ -7,6 +7,7 @@
fields = ["bar", "baz"],
)
+# buildifier: disable=unsorted-dict-items
MyVeryDocumentedInfo = provider(
doc = """
A provider with some really neat documentation.
diff --git a/test/testdata/providers_for_attributes_test/input.bzl b/test/testdata/providers_for_attributes_test/input.bzl
index a9b4e19..1fb4ea2 100644
--- a/test/testdata/providers_for_attributes_test/input.bzl
+++ b/test/testdata/providers_for_attributes_test/input.bzl
@@ -3,9 +3,11 @@
load(":testdata/providers_for_attributes_test/dep.bzl", "DepProviderInfo")
def my_rule_impl(ctx):
+ _ignore = [ctx] # @unused
return []
# buildifier: disable=provider-params
+# buildifier: disable=unsorted-dict-items
MyProviderInfo = provider(
fields = {
"foo": "Something foo-related.",
@@ -17,6 +19,7 @@
OtherProviderInfo = provider()
other_provider_info = OtherProviderInfo(fields = ["foo"])
+# buildifier: disable=unsorted-dict-items
my_rule = rule(
implementation = my_rule_impl,
doc = "This rule does things.",
diff --git a/test/testdata/py_rule_test/input.bzl b/test/testdata/py_rule_test/input.bzl
index 0d6bc16..289738b 100644
--- a/test/testdata/py_rule_test/input.bzl
+++ b/test/testdata/py_rule_test/input.bzl
@@ -1,14 +1,16 @@
"""The input file for the python rule test"""
def exercise_the_api():
- var1 = PyRuntimeInfo
- var2 = PyInfo
+ var1 = PyRuntimeInfo # @unused
+ var2 = PyInfo # @unused
exercise_the_api()
def my_rule_impl(ctx):
+ _ignore = [ctx] # @unused
return []
+# buildifier: disable=unsorted-dict-items
py_related_rule = rule(
implementation = my_rule_impl,
doc = "This rule does python-related things.",
diff --git a/test/testdata/same_level_file_test/dep.bzl b/test/testdata/same_level_file_test/dep.bzl
index 87750b3..f6a7f64 100644
--- a/test/testdata/same_level_file_test/dep.bzl
+++ b/test/testdata/same_level_file_test/dep.bzl
@@ -1,5 +1,5 @@
# buildifier: disable=module-docstring
# buildifier: disable=function-docstring
def my_rule_impl(ctx):
- _ignore = [ctx]
+ _ignore = [ctx] # @unused
return struct()
diff --git a/test/testdata/simple_test/input.bzl b/test/testdata/simple_test/input.bzl
index fe0ffc7..0e3243d 100644
--- a/test/testdata/simple_test/input.bzl
+++ b/test/testdata/simple_test/input.bzl
@@ -1,7 +1,9 @@
# buildifier: disable=module-docstring
def my_rule_impl(ctx):
+ _ignore = [ctx] # @unused
return []
+# buildifier: disable=unsorted-dict-items
my_rule = rule(
implementation = my_rule_impl,
doc = "This is my rule. It does stuff.",
diff --git a/test/testdata/struct_default_value_test/input.bzl b/test/testdata/struct_default_value_test/input.bzl
index ead514b..a328b66 100644
--- a/test/testdata/struct_default_value_test/input.bzl
+++ b/test/testdata/struct_default_value_test/input.bzl
@@ -1,5 +1,6 @@
"""The input file for struct default values test"""
+# buildifier: disable=unused-variable
def check_struct_default_values(
struct_no_args = struct(),
struct_arg = struct(foo = "bar"),
diff --git a/test/testdata/unknown_name_test/input.bzl b/test/testdata/unknown_name_test/input.bzl
index 062f49d..3716325 100644
--- a/test/testdata/unknown_name_test/input.bzl
+++ b/test/testdata/unknown_name_test/input.bzl
@@ -1,7 +1,9 @@
# buildifier: disable=module-docstring
def my_rule_impl(ctx):
+ _ignore = [ctx] # @unused
return []
+# buildifier: disable=unsorted-dict-items
rule(
implementation = my_rule_impl,
attrs = {
